chore(marketing): update trusted by section#3892
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 11 minutes and 37 seconds.Comment |
Greptile SummaryThis PR updates the "Trusted By" section on the marketing page, replacing the Ramp logo with a new Toss wordmark SVG. The SVG is well-formed and the component entry follows the established pattern exactly. Confidence Score: 5/5Safe to merge — purely a content swap in a static logo list with no logic changes. The change is a straightforward logo replacement: a new SVG asset is added and a single array entry is updated. No logic, auth, or data-handling is affected. All findings are P2 or lower, so the score is 5. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/marketing/public/logos/toss-wordmark.svg | New SVG asset for the Toss wordmark; valid SVG with a defined viewBox and no issues. |
| apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx | Replaces the "ramp" logo entry with "toss"; follows the existing CLIENT_LOGOS pattern correctly. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CLIENT_LOGOS array] --> B[toss entry replaces ramp]
B --> C[toss-wordmark.svg new asset]
A --> D[TrustedBySection render]
D --> E[Mobile grid layout]
D --> F[Desktop two-row layout]
Reviews (1): Last reviewed commit: "chore(marketing): update trusted by sect..." | Re-trigger Greptile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx (1)
93-101: 💤 Low valueOptional refactor: replace the inline
as { ... }[]assertion with a named type /satisfies.This works, but the anonymous inline type is verbose and harder to reuse/extend. Consider introducing a
type ClientLogo = { ... }(or usingas const satisfies ClientLogo[]) and then declaringconst CLIENT_LOGOS: ClientLogo[] = [...]for clearer intent and safer maintenance.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx` around lines 93 - 101, Replace the anonymous inline assertion used for CLIENT_LOGOS with a named type to improve readability and reuse: create a type (e.g., ClientLogo) matching the shape (name, label, logo, height, marginTop?, borderRadius?, invert?) and then declare the constant as either const CLIENT_LOGOS: ClientLogo[] = [...] or use "as const" with "satisfies ClientLogo[]" to get stricter checking; update any usages in TrustedBySection.tsx to reference the new ClientLogo type if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx`:
- Around line 62-67: The toss logo object in TrustedBySection (the entry with
name: "toss") relies on default invert behavior because it doesn't specify
invert, causing it to be rendered with grayscale brightness-0 invert; explicitly
add invert: false to that toss entry (in the clients/logos array used by
TrustedBySection) so the Image styling won't apply the invert filter for the
toss-wordmark.svg and it renders with correct colors.
---
Nitpick comments:
In `@apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx`:
- Around line 93-101: Replace the anonymous inline assertion used for
CLIENT_LOGOS with a named type to improve readability and reuse: create a type
(e.g., ClientLogo) matching the shape (name, label, logo, height, marginTop?,
borderRadius?, invert?) and then declare the constant as either const
CLIENT_LOGOS: ClientLogo[] = [...] or use "as const" with "satisfies
ClientLogo[]" to get stricter checking; update any usages in
TrustedBySection.tsx to reference the new ClientLogo type if needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 12c7d23d-1f21-4cdf-9014-ce6fa962dbc6
⛔ Files ignored due to path filters (1)
apps/marketing/public/logos/toss-wordmark.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
apps/marketing/src/app/components/TrustedBySection/TrustedBySection.tsx
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
* chore(marketing): update trusted by section * chore(marketing): tweak trusted by section * chore(marketing): tweak trusted by section
1 participant
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by cubic
Replaced Ramp with Toss in the marketing site's Trusted By section. Added
apps/marketing/public/logos/toss-wordmark.svgand updatedTrustedBySectionto use the Toss logo (height 18).Written for commit 83118a4. Summary will update on new commits. Review in cubic
Summary by CodeRabbit